Skip to content

ZHA group and device cleanup#31260

Merged
Adminiuga merged 15 commits into
home-assistant:devfrom
dmulcahey:dm/zha-cleanup-groups-devices
Jan 29, 2020
Merged

ZHA group and device cleanup#31260
Adminiuga merged 15 commits into
home-assistant:devfrom
dmulcahey:dm/zha-cleanup-groups-devices

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

@dmulcahey dmulcahey commented Jan 28, 2020

Proposed change

This PR cleans up the group functionality that was added recently so that it can be expanded upon. This provides a foundation that can be used to represent groups in the UI. I also cleaned up a few minor things in the device object.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@dmulcahey dmulcahey force-pushed the dm/zha-cleanup-groups-devices branch from b9d5e40 to 02267c8 Compare January 29, 2020 12:06
@dmulcahey dmulcahey changed the title RFC - ZHA group and device cleanup ZHA group and device cleanup Jan 29, 2020
@dmulcahey dmulcahey marked this pull request as ready for review January 29, 2020 15:47
@dmulcahey dmulcahey requested a review from Adminiuga as a code owner January 29, 2020 15:48
Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adminiuga Adminiuga merged commit f4a4c6b into home-assistant:dev Jan 29, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 30, 2020
@dmulcahey dmulcahey deleted the dm/zha-cleanup-groups-devices branch March 26, 2020 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants