Add opening and closing states to MQTT covers#31259
Merged
MartinHjelmare merged 5 commits intoJan 30, 2020
Merged
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
7 tasks
24a7c1c to
2aa6926
Compare
Contributor
7 tasks
2aa6926 to
9c343a4
Compare
MartinHjelmare
requested changes
Jan 28, 2020
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please remove the use of STATE_UNKNOWN.
Member
20 tasks
Contributor
Author
|
@MartinHjelmare Test added 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Home assistent has support for the
openingandclosingstate for covers. However, the MQTT component does not expose a way to set this state from the state topic. This PR adds that functionality for devices that are able to proactively report whether they're opening or closing, perhaps from an analog input not connected to HA.This change is purely additive, the existing features will keep working and the extra configuration options are optional.
Related feature request: https://community.home-assistant.io/t/garage-door-state-opening-closing-state-from-mqtt-sensor/71263
Type of change
Example entry for
configuration.yaml:(Optional custom payload, inline with the existing options)
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: