Skip to content

Add sighthound save image#31199

Closed
robmarkcole wants to merge 2 commits into
home-assistant:devfrom
robmarkcole:adds_sighthoung_save_image
Closed

Add sighthound save image#31199
robmarkcole wants to merge 2 commits into
home-assistant:devfrom
robmarkcole:adds_sighthoung_save_image

Conversation

@robmarkcole
Copy link
Copy Markdown
Contributor

@robmarkcole robmarkcole commented Jan 27, 2020

Proposed change

Adds a config option which enables saving of an annotated image. I've not added a test as unsure how to test this safely, looking for recommendations. Docs PR home-assistant/home-assistant.io#11887

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
image_processing:
  - platform: sighthound
    api_key: my_key
    save_file_folder: /my_dir
    source:
      - entity_id: camera.local_file

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@robmarkcole
Copy link
Copy Markdown
Contributor Author

For discussion, but we probably want to implement save_image on the image processing class, as it is used (in slightly different ways) by doods and tensorflow also

@MartinHjelmare MartinHjelmare changed the title Adds sighthound save image Add sighthound save image Jan 28, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2020

Codecov Report

Merging #31199 into dev will decrease coverage by 0.01%.
The diff coverage is 52.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31199      +/-   ##
==========================================
- Coverage   94.67%   94.66%   -0.02%     
==========================================
  Files         763      763              
  Lines       55152    55172      +20     
==========================================
+ Hits        52217    52227      +10     
- Misses       2935     2945      +10
Impacted Files Coverage Δ
...ssistant/components/sighthound/image_processing.py 86.41% <52.38%> (-11.95%) ⬇️
homeassistant/components/template/cover.py 96.34% <0%> (-1.37%) ⬇️
homeassistant/util/pil.py 30% <0%> (+30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fda7d...b31d059. Read the comment docs.

@robmarkcole
Copy link
Copy Markdown
Contributor Author

Closing as this should really be a convenience method on image_processing

@lock lock Bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants