Skip to content

Change scan_interval settings for Tesla to allow automation flexibility#31194

Merged
Adminiuga merged 1 commit into
home-assistant:devfrom
alandtse:new_defaults
Jan 30, 2020
Merged

Change scan_interval settings for Tesla to allow automation flexibility#31194
Adminiuga merged 1 commit into
home-assistant:devfrom
alandtse:new_defaults

Conversation

@alandtse
Copy link
Copy Markdown
Contributor

@alandtse alandtse commented Jan 27, 2020

Breaking change

Tesla default SCAN_INTERVAL has been raised to 660 seconds from 300 seconds. This is the result of new testing showing the prior default would not allow Tesla vehicles to fall asleep. You should reevaluate your SCAN_INTERVAL if you have changed it to avoid battery drain. The SCAN_INTERVAL has had the minimum lowered to 60.

Proposed change

SCAN_INTERVAL default has been changed to 660 and minimum set to 60. The new minimum allows those use automations to potentially create an adaptive refresh algorithm.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added has-tests integration: tesla removed integration small-pr PRs with less than 30 lines. labels Jan 27, 2020
@probot-home-assistant
Copy link
Copy Markdown

Hey there @zabuldon, mind taking a look at this pull request as its been labeled with a integration (tesla) you are listed as a codeowner for? Thanks!

Copy link
Copy Markdown
Contributor

@pnbruckner pnbruckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and doc changes have already been approved, so allowing a much smaller minimum interval has tacitly been approved.

@MartinHjelmare MartinHjelmare changed the title Changed scan_interval settings for Tesla to allow automation flexibility Change scan_interval settings for Tesla to allow automation flexibility Jan 29, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mention the change of min scan interval in the breaking change paragraph.

@Adminiuga Adminiuga merged commit cf0e467 into home-assistant:dev Jan 30, 2020
@alandtse
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare I made the note in the breaking change paragraph but it occurred after it was merged. Is there anything further that needs to be done? Or will it be automatically pulled when building the release?

@MartinHjelmare
Copy link
Copy Markdown
Member

It will not be pulled automatically, as far as I know, but the release hasn't been done yet, so I don't think we have collected the release notes yet.

@lock lock Bot locked and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tesla does not sleep with default polling interval

5 participants