Change scan_interval settings for Tesla to allow automation flexibility#31194
Merged
Conversation
7 tasks
39a2dc8 to
ee73d56
Compare
pnbruckner
approved these changes
Jan 29, 2020
Contributor
pnbruckner
left a comment
There was a problem hiding this comment.
Looks good to me, and doc changes have already been approved, so allowing a much smaller minimum interval has tacitly been approved.
MartinHjelmare
approved these changes
Jan 29, 2020
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please also mention the change of min scan interval in the breaking change paragraph.
Contributor
Author
|
@MartinHjelmare I made the note in the breaking change paragraph but it occurred after it was merged. Is there anything further that needs to be done? Or will it be automatically pulled when building the release? |
Member
|
It will not be pulled automatically, as far as I know, but the release hasn't been done yet, so I don't think we have collected the release notes yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Tesla default SCAN_INTERVAL has been raised to 660 seconds from 300 seconds. This is the result of new testing showing the prior default would not allow Tesla vehicles to fall asleep. You should reevaluate your SCAN_INTERVAL if you have changed it to avoid battery drain. The SCAN_INTERVAL has had the minimum lowered to 60.Proposed change
SCAN_INTERVAL default has been changed to 660 and minimum set to 60. The new minimum allows those use automations to potentially create an adaptive refresh algorithm.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: