Add initial version of Vilfo Router integration#31177
Conversation
Quentame
added
cla-recheck
and removed
has-tests
integration: vilfo
new-integration
labels
|
Sorry for the spam I made a mistake |
|
No worries! Were you trying to fix the |
|
Yeppa, I don't know why you have this now (also I was on a mobile app, and when I've add The recheck is not removing it. I'll let people who knows taking take of it. Or maybe "ManneW authored and Emanuel Winblad committed" on the first commit, try rebase and force push, so it will be you the author and committer. So, I'll review soon 😊 |
|
I actually did amend the "author" part to resolve the CLA issue from the beginning (before that it was only "Emanuel Winblad" and not "ManneW") 😄 But your suggestion was a good idea, so I did the rebase now to have things a bit cleaner 🙂Not sure if the |
Quentame
left a comment
Quentame
left a comment
There was a problem hiding this comment.
Why there is a src/vilfo-api-client submodule here ?
It shouldn't be.
|
|
* Changes to constant names, * Blocking IO separated to executor job, * Data for uptime sensor changed from being computed to being a timestamp, * Started refactoring uptime sensor in terms of naming and unit. * Updated constants for boot time (previously uptime) sensor. * Refactored test of Vilfo config flow to avoid patching code under test. * UI naming fixes and better exception handling.
* Removed unit of measurement for boot time sensor, * Added support for a sensor not having a unit, * Updated the config_flow to handle when the integration is already configured, * Updated tests to avoid mocking the code under test and also to cover the aforementioned changes.
|
I've updated (but not pushed yet) this based on the last comments from @MartinHjelmare. Do you want me to squash all the work into a single commit? I'll push it as a single new commit in the meantime, but are ready to do some squashing to keep the repo as clean as possible 😄 |
|
Please don't squash commits after review has started to make it easier for readers to track changes. We'll squash when merging. 👍 |
|
Can be merged when build passes. |
|
Thank you for great review feedback, @MartinHjelmare and @Quentame! 🙏 No worries, @Quentame! 😄 I guess it would be good if you also marked your original review as "approved" (or if one can remove the review or something?) so that the PR can be sorted accordingly 🙂 |
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Sorry, I think I've missed this.
Quentame
left a comment
Quentame
left a comment
There was a problem hiding this comment.
3 comments more before merging
…nt library doing I/O in async context.
This comment has been minimized.
This comment has been minimized.
|
Very nice work @ManneW ! Thanks for contributing 👏 |
4 participants
Proposed change
New integration added for the Vilfo Router (https://www.vilfo.com). The Vilfo Router is a VPN router with an HTTP API. In this initial version, the integration only provides a couple of sensors to monitor the status of the router. The idea is to add device tracking soon after this initial version (but as the guidelines states, this first version is limited to a single platform).
Type of change
Example entry for
configuration.yaml:Integration only supports config_flow configuration.
Additional information
Checklist
black --fast homeassistant tests)For the
config_flowpart of the integration:If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.