Add SUPPORT_VOLUME_STEP for older Pioneer receivers#31023
Merged
Conversation
springstan
approved these changes
Feb 1, 2020
Contributor
Author
|
Thanks for the review @springstan. What is needed to get it merged? Thanks. |
Member
|
@Cloudenius you could update the docs to include an example for the Pioneer VSX-528 model to show that even these older models work with this integration :) |
7 tasks
Contributor
Author
Done! See doc PR attached. I must say that the telnet connection isn't always reliable and I have to disconnect it from power every couple of weeks to get it to work again. Otherwise it will report that the telnet connection was closed. But the app has the same issues, so it seems like an issue with the device itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Older Pioneer models like the Pioneer VSX-528 require
SUPPORT_VOLUME_STEPto control the volume.Doc PR: home-assistant/home-assistant.io#11952
Checklist:
tox. Your PR cannot be merged unless tests pass