Skip to content

Add SUPPORT_VOLUME_STEP for older Pioneer receivers#31023

Merged
springstan merged 1 commit into
home-assistant:devfrom
DevSecNinja:dev
Feb 2, 2020
Merged

Add SUPPORT_VOLUME_STEP for older Pioneer receivers#31023
springstan merged 1 commit into
home-assistant:devfrom
DevSecNinja:dev

Conversation

@DevSecNinja
Copy link
Copy Markdown
Contributor

@DevSecNinja DevSecNinja commented Jan 20, 2020

Description:

Older Pioneer models like the Pioneer VSX-528 require SUPPORT_VOLUME_STEP to control the volume.

Doc PR: home-assistant/home-assistant.io#11952

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@DevSecNinja
Copy link
Copy Markdown
Contributor Author

Thanks for the review @springstan. What is needed to get it merged?

Thanks.

@springstan
Copy link
Copy Markdown
Member

springstan commented Feb 2, 2020

@Cloudenius you could update the docs to include an example for the Pioneer VSX-528 model to show that even these older models work with this integration :)

@DevSecNinja
Copy link
Copy Markdown
Contributor Author

@Cloudenius you could update the docs to include an example for the Pioneer VSX-528 model to show that even these older versions work with this integration :)

Done! See doc PR attached. I must say that the telnet connection isn't always reliable and I have to disconnect it from power every couple of weeks to get it to work again. Otherwise it will report that the telnet connection was closed. But the app has the same issues, so it seems like an issue with the device itself.

@springstan springstan changed the title Enable SUPPORT_VOLUME_STEP for older Pioneer receivers Add SUPPORT_VOLUME_STEP for older Pioneer receivers Feb 2, 2020
@springstan springstan merged commit f21a058 into home-assistant:dev Feb 2, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants