Remove monitored conditions from OpenUV#31019
Merged
balloob merged 2 commits intoJan 23, 2020
Merged
Conversation
2 tasks
bachya
force-pushed
the
openuv-remove-monitored-conditions
branch
from
d645d34 to
226e904
Compare
pvizeli
reviewed
Jan 22, 2020
| UV_LEVEL_MODERATE = "Moderate" | ||
| UV_LEVEL_LOW = "Low" | ||
|
|
||
| SENSORS = { |
Member
There was a problem hiding this comment.
All the constants maybe into const.py inside integration?
Contributor
Author
There was a problem hiding this comment.
I traditionally haven't done this; instead, I've followed the pattern used by HASS itself (centralize a constant into const.py if it is used in more than one place, otherwise define it where it is used). Should I not be doing that?
MartinHjelmare
approved these changes
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
It is no longer possible to specify monitored conditions within the OpenUV integration; all entities are added by default.
Description:
Per ADR 0003, this PR removes the concept of monitored conditions from OpenUV. All entity types are added by default. The integration uses more than one API call, but since we update the entities via service call (and all service calls are available by default), I made the choice to include everything.
This PR also includes a config entry migration to clean up monitored conditions data as necessary.
Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11825
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: