Fix deCONZ update entry from Hassio discovery#31015
Merged
Merged
Conversation
probot-home-assistant
Bot
added
integration: deconz
small-pr
pvizeli
approved these changes
Jan 20, 2020
Member
|
Yes of course... Thanks Frenck for catching that! |
frenck
added a commit
that referenced
this pull request
Jan 21, 2020
* Fix deCONZ update entry from Hassio discovery * Empty commit to re-trigger build
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The deCONZ integration check for existing entries based on
hass.datawhen an Hass.io deCONZ is discovered. However, that doesn't have to be set up yet causing a new instance to be discovered, which is incorrect.Instead, it should have updated the existing entry.
This PR addresses the issue to not rely on
hass.databut use the set upconfig_entriesin Home Assistant itself.Related issue (if applicable): fixes home-assistant/addons#1007
Checklist:
tox. Your PR cannot be merged unless tests pass