Add Salt Fiber Box device tracker#30986
Merged
MartinHjelmare merged 15 commits intoFeb 2, 2020
Merged
Conversation
2 tasks
0c9489c to
c9e86d5
Compare
elupus
reviewed
Jan 28, 2020
Contributor
elupus
left a comment
There was a problem hiding this comment.
I'm not at all up to date on device trackers, so just consider this some minor review.
springstan
reviewed
Feb 1, 2020
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
23ea189 to
3f9c1bd
Compare
MartinHjelmare
requested changes
Feb 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Implements a device_tracker platform for the Salt Fiber Box. Salt is a Swiss internet provider.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11811
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: