Skip to content

Allow hourly forecast in IPMA#30979

Merged
Adminiuga merged 19 commits into
home-assistant:devfrom
abmantis:pyipma_hourly
Feb 14, 2020
Merged

Allow hourly forecast in IPMA#30979
Adminiuga merged 19 commits into
home-assistant:devfrom
abmantis:pyipma_hourly

Conversation

@abmantis
Copy link
Copy Markdown
Member

@abmantis abmantis commented Jan 19, 2020 •
edited
Loading

Description:

Add support for hourly forecast, in addition to the existing daily forecast. This is controlled by a new "mode" config attribute.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11809

Example entry for configuration.yaml (if applicable):

weather:
  - platform: ipma
    name: Home
    latitude: 123.123
    longitude: -1.234
    mode: hourly

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

abmantis added 11 commits January 11, 2020 00:08
@abmantis
update ipma component for pyipma 2.0
e63517e
@abmantis
Merge branch 'dev' of https://github.com/home-assistant/home-assistant …
a41976a 
…into pyipma_update
@abmantis
fix wind speed; refactor forecast
9e8a2e5
@abmantis
update requirements*.txt
752dc5f
@abmantis
Merge branch 'dev' of https://github.com/home-assistant/home-assistant …
b9b59d2 
…into pyipma_update
@abmantis
fix tests; update CODEOWNERS; update pyipma to 2.0.1
7fdee81
@abmantis
minor changes as suggested in PR
0f36c9d
@abmantis
make lint happy
f72aedf
@abmantis
Merge branch 'dev' of https://github.com/home-assistant/home-assistant …
ff7ca8b 
…into pyipma_update
@abmantis
Merge branch 'dev' of https://github.com/home-assistant/home-assistant …
b0ae636 
…into pyipma_update
@abmantis
fix mocking coroutines
dab8df6
@abmantis abmantis requested a review from dgomes as a code owner January 19, 2020 19:01
@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented Jan 19, 2020

Hey there @dgomes, mind taking a look at this pull request as its been labeled with a integration (ipma) you are listed as a codeowner for? Thanks!

@abmantis abmantis mentioned this pull request Jan 19, 2020
Merged
2 tasks
@dgomes
Copy link
Copy Markdown
Contributor

dgomes commented Jan 19, 2020

I think this will need to be rebased after #30746

@abmantis abmantis force-pushed the pyipma_hourly branch 2 times, most recently from c24e842 to 778342a Compare January 20, 2020 22:26
@abmantis
Copy link
Copy Markdown
Member Author

abmantis commented Jan 29, 2020

@dgomes can you review please?

dgomes
dgomes approved these changes Jan 29, 2020
View reviewed changes
Comment thread homeassistant/components/ipma/weather.py Outdated
Comment thread tests/components/ipma/test_weather.py
@abmantis
Copy link
Copy Markdown
Member Author

abmantis commented Feb 8, 2020

What is missing to merge this?

Adminiuga
Adminiuga approved these changes Feb 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Adminiuga Adminiuga merged commit e6148d2 into home-assistant:dev Feb 14, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dgomes dgomes dgomes approved these changes

@Adminiuga Adminiuga Adminiuga approved these changes

Assignees

@dgomes dgomes

Labels

cla-signed has-tests integration: ipma

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abmantis @dgomes @Adminiuga @homeassistant