Ring camera fix#30975
Merged
Merged
Conversation
probot-home-assistant
Bot
added
integration: ring
small-pr
balloob
reviewed
Jan 19, 2020
| self._last_video_id = None | ||
| self._video_url = None | ||
| self._expires_at = self._utcnow | ||
| self._expires_at = dt_util.utcnow() |
Member
There was a problem hiding this comment.
This should be forcing an expiration, so:
Suggested change
| self._expires_at = dt_util.utcnow() | |
| self._expires_at = dt_util.utcnow() - FORCE_REFRESH_INTERVAL |
Member
There was a problem hiding this comment.
Guess it doesn't matter. It's None anyway.
frenck
pushed a commit
that referenced
this pull request
Jan 21, 2020
* Fix ring camera entities * Reverted test refresh interval * Fix black errors
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The ring API generates a unique URL valid for an hour which is used in the camera component. There is a utcnow check in the HA ring component that is always static, so it is always early returning. This PR updates the utcnow checks in the Ring camera component to generate a new URL every 45 minutes.
fixes python-ring-doorbell/python-ring-doorbell#191