Fix Alexa semantics for covers with tilt support.#30911
Merged
Conversation
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
balloob
approved these changes
Jan 17, 2020
balloob
pushed a commit
that referenced
this pull request
Jan 17, 2020
* Fix Alexa semantics for covers with tilt support. * Clarify wording. * Korrect grammar.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
After extensive testing; the following PR clears up some ambiguity from the Alexa documentation pertaining to semantics. Fixes issue introduced in 0.104.
In order for Alexa semantics to work with multiple controllers and in each of the supported locales the following guidelines need to be followed:
Related issue (if applicable): fixes #30852 fixes #30830
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: