Skip to content

Support Pro alarm panel, embrace async, leverage latest HA features/architecture#30893

Closed
kit-klein wants to merge 2 commits into
home-assistant:devfrom
konnected-io:async_pro
Closed

Support Pro alarm panel, embrace async, leverage latest HA features/architecture#30893
kit-klein wants to merge 2 commits into
home-assistant:devfrom
konnected-io:async_pro

Conversation

@kit-klein
Copy link
Copy Markdown
Contributor

@kit-klein kit-klein commented Jan 17, 2020

Description:

This PR updates the Konnected component to support the soon to be released Konnected Alarm Panel Pro. It also brings the Konnected component up to date with the latest HA architecture and features. Notable changes are...

  • config flow and config entries support
  • all config schema defns moved to config_flow.py
  • migrated discovery to use ssdp via config flows
  • device registry support
  • uses updated async konnected pypi module
  • extracted the konnected alarm panel interface and state management into a separate module (panel.py).
  • all cached state now references zone ids instead of pin
  • tests added for init, config flow, and panel modules

All changes are backward compatible with existing configuration.yaml based configs. The yaml based configs will be imported into a config entry if a matching entry does not exist.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11785

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link
Copy Markdown

This pull request needs to be manually signed off by @balloob before it can get merged.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @heythisisnate, mind taking a look at this pull request as its been labeled with a integration (konnected) you are listed as a codeowner for? Thanks!

@homeassistant
Copy link
Copy Markdown
Contributor

Hello @kit-klein,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@kit-klein kit-klein closed this Jan 17, 2020
@kit-klein kit-klein deleted the async_pro branch January 17, 2020 14:32
@lock lock Bot locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants