Make gen_requirements_all.py case insensitive for ignored packages#30885
Merged
Conversation
springstan
approved these changes
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When I was working on implementing a new platform I have added
RPi.GPIOto the requirements. It turns out this was actually a blacklisted component ingen_all_requirements.pybut because I have accidentally wroteRPI.GPIOinstead (same component, different case) it got added torequirements_all.txtanyway.This caused
pylintto fail on a completely different, but already approved component in the dev branch (rpi_gpio). Since it took a while to track down this problem I figured I might as well fixgen_requirements_all.pyto ignore case when matching against blacklisted packages.Related issue (if applicable): #30837
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: