Fix sensor type creation with multiple Ambient weather stations#30850
Merged
Conversation
balloob
approved these changes
Jan 16, 2020
Member
balloob
left a comment
There was a problem hiding this comment.
Ok to fix this now. We should move to drop monitored conditions as per adr 003
Contributor
Author
|
@balloob Even though I use the |
Member
|
Ok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
ambient_pwsintegration had a bug where, despite supporting multiple weather stations, the same sensor types would be created for every station – even if different stations had different sensor types attached to them. This PR fixes that.Related issue (if applicable): fixes #30513
Pull request with documentation for home-assistant.io (if applicable): N/A
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass