Skip to content

Bump librouteros to 3.0.0#30800

Merged
balloob merged 1 commit into
home-assistant:devfrom
springstan:bump-librouteros
Jan 15, 2020
Merged

Bump librouteros to 3.0.0#30800
balloob merged 1 commit into
home-assistant:devfrom
springstan:bump-librouteros

Conversation

@springstan
Copy link
Copy Markdown
Member

@springstan springstan commented Jan 15, 2020

Breaking Change:

Before you did not have to specify the login_method parameter since both login_methods would be attempted.
Now the behaviour has changed and the login_method token is used by default.
You will need to adjust the login_method accordingly.

Description:

Related issue (if applicable): fixes #30745

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11755

Example entry for configuration.yaml (if applicable):

mikrotik:
  - host: 192.168.1.1
    username: secret
    password: secret
    login_method: plain
    port: 8728

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 3899c6a into home-assistant:dev Jan 15, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 16, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

We should mark this a breaking change since we're changing how we try to log in to the router based on the config option.

@balloob
Copy link
Copy Markdown
Member

balloob commented Feb 1, 2020

Could you add a paragraph @springstan

@springstan
Copy link
Copy Markdown
Member Author

Sure!

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Feb 1, 2020

We should write the breaking change paragraph user facing. Before, if the user didn't set the login method option, both login methods were tried. Now, if the user don't set the login method option, the token method is used.

@springstan
Copy link
Copy Markdown
Member Author

Done.

@MartinHjelmare
Copy link
Copy Markdown
Member

Thanks! 👍

@springstan
Copy link
Copy Markdown
Member Author

Of course! ✌

@springstan springstan deleted the bump-librouteros branch April 7, 2020 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mikrotik hub is broken?

4 participants