Add Garmin Connect integration#30792
Conversation
|
Looking into flake8 failure. |
|
Need to decide about correct/wanted config name for the resources. CONF_MONITORED_CONDITIONS But FitBit uses a local declared: CONF_MONITORED_RESOURCES = "monitored_resources" And I believe there is also a: CONF_RESOURCES Any suggestion/preferences? |
Doing a fgrep -R inside the components directory shows that the usage of CONF_MONITORED_CONDITIONS is the highest, so sticking with that one. |
|
We're phasing out the usage of monitored conditions per ADR-003. Please remove that support. |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please use the core interfaces in the test to make them more robust.
|
Just want to poke in and say thanks @cyberjunky for diving into this and @MartinHjelmare for all of your patience and assistance on the code review. Really looking forward to having this integration for myself! |
|
I see this error in the CI logs pytest for python37: |
|
The netatmo integration is missing an init module in its test package. If you have time, you can open a separate PR and just add an |
|
Done #31189 |
|
I think I have applied all requested changes, I have one thing left; This change let the test_config_flow mock and the check fail again for the already configured test: |
Description:
Provides sensors for quite a few values exposed in Garmin Connect.
Implemented async and configflow, dropped yaml cfg for now
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11752
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: