Add wiffi integration#30784
Merged
MartinHjelmare merged 18 commits intohome-assistant:devfrom May 13, 2020
Merged
Conversation
2 tasks
frenck
reviewed
Jan 15, 2020
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Member
|
Thanks, stalebot, but this PR awaits an initial review from us. |
MartinHjelmare
requested changes
Apr 15, 2020
Member
|
The config flow needs 100% test coverage. You can use the scaffold script to help get started with those tests. |
Member
|
Please make sure that all checks pass. They are available here: |
MartinHjelmare
approved these changes
Apr 27, 2020
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Good! Just one more thing that needs addressing. Then we can merge.
Member
|
We need to hold here for a bit until we've fixed our tests on dev branch. Please stay tuned. |
Member
|
@mampfes if you rebase the ci should pass |
wiffi devices are DIY board manufactured by stall.biz. Several devices are available, e.g. a weather station (weatherman), an indoor environmental sensor (wiffi-wz) and some more. This intgration has been developed using a weatherman device, but should also work for other devices from stall.biz.
- move wiffi specific code to pypi - remove yaml configuration code
remove debug log rename .translations to translations
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
WIFFI devices are DIY boards manufactured by stall.biz.
Several devices are available, e.g. a weather station (weatherman), an
indoor environmental sensor (wiffi-wz) and some more.
This integration has been developed using a weatherman device, but should
also work for other devices from stall.biz.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11748
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.