Skip to content

Search: Add search to default config and don't resolve area #30762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 3 commits into from
Jan 15, 2020
Merged

Search: Add search to default config and don't resolve area #30762

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4671172
Add search to default config and don't resolve area
bramkragten Jan 14, 2020
72d04a4
Move to frontend
bramkragten Jan 14, 2020
e96fddd
Minor update
awarecan Jan 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion homeassistant/components/default_config/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"sun",
"system_health",
"updater",
"zeroconf"
"zeroconf",
"search"

@balloob balloob Jan 14, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of default_config? I think that it should be part of frontend?

@bramkragten bramkragten Jan 14, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, then I don't have to check if it is loaded :-)

],
"codeowners": []
}
2 changes: 1 addition & 1 deletion homeassistant/components/search/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class Searcher:
"""

# These types won't be further explored. Config entries + Output types.
DONT_RESOLVE = {"scene", "automation", "script", "group", "config_entry"}
DONT_RESOLVE = {"scene", "automation", "script", "group", "config_entry", "area"}

def __init__(
self,
Expand Down