Fix hassfest allowing omitting discovery methods when using OAuth2Flow#30732
Merged
Conversation
22 tasks
balloob
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
If an integration implements the AbstractOAuth2FlowHandler, the following steps may be omitted:
async_step_homekitasync_step_ssdpasync_step_zeroconfSince the AbstractOAuth2FlowHandler provides defaults for these steps.
Related PR: #30717
Checklist:
tox. Your PR cannot be merged unless tests pass