Add support for displaying Daf Yomi

[moshekaplan]

Description:

Add support for displaying the day's Daf Yomi to the jewish_calendar component.

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[homeassistant]

Hi @moshekaplan,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @tsvi, mind taking a look at this pull request as its been labeled with a integration (jewish_calendar) you are listed as a codeowner for? Thanks!

[tsvi]

Hi @moshekaplan,

Thank you very much for your contribution.
Unfortunately, you will need to split up the code between the hdate package which is used by the Jewish calendar and the code in home assistant.

The homeassistant maintainers try to keep the non- homeassistant code to a minimum.

Please open a PR on royi1000/py-libhdate with the code for calculating the daf. (Yes, I know the code there is a bit a mess, help is more than welcome).

Once we've got that code working, I'll upload a new version to pypi which you can then use here.

It's a bit cumbersome, but it helps keeping the code in homeassistant clean.

Thank you,

Tsvi

[moshekaplan]

Submitted py-libhdate/py-libhdate#46 . Once the daf yomi code is merged in there, this code can be modified to use the updated library.

[tsvi]

Hi @moshekaplan

I just published version 0.9.4 of hdate. You can now continue with this PR. Don't forget after updating the manifest to run gen_requirements_all.

Thanks,

Tsvi

[tsvi]

I was a bit to trigger happy. Please take 0.9.5 which passes tox.

[moshekaplan]

@tsvi : Could you review this again?

[tsvi]

You also should update the tests and add a check for the daf yomi sensor in there as well.

[moshekaplan]

@tsvi : We might be good to go. Can you review again?

[tsvi]

Looks ok to me

[moshekaplan]

@fabaff : Could you please review this again?

[springstan]

LGTM ✌