Skip to content

Convert vizio component from sync to async component#30605

Merged
MartinHjelmare merged 10 commits into
home-assistant:devfrom
raman325:vizio_async
Jan 10, 2020
Merged

Convert vizio component from sync to async component#30605
MartinHjelmare merged 10 commits into
home-assistant:devfrom
raman325:vizio_async

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Jan 9, 2020

Description:

I updated pyvizio to include async support and have updated the HA component to use the async class. In addition, I:

  • Added type hinting wherever I could to make future changes easier

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Comment thread homeassistant/components/vizio/__init__.py
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Comment thread homeassistant/components/vizio/media_player.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this.

Comment thread homeassistant/components/vizio/media_player.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit d25aa1f into home-assistant:dev Jan 10, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants