Add temperature support to light template#30595
Merged
balloob merged 2 commits intoJan 23, 2020
Merged
Conversation
|
Hey there @PhracturedBlue, mind taking a look at this pull request as its been labeled with a integration ( |
2 tasks
balloob
reviewed
Jan 23, 2020
| @callback | ||
| def update_temperature(self): | ||
| """Update the temperature from the template.""" | ||
| if self._temperature_template is not None: |
Member
There was a problem hiding this comment.
Use a guard clause: if self._temperature_template is None: return. Even better would be to not even call this function if not necessary.
balloob
approved these changes
Jan 23, 2020
Member
balloob
left a comment
There was a problem hiding this comment.
Looking great. Ok to merge after final comment addressed.
Contributor
Author
|
Thx @balloob for your review. I've added the guard clause to other methods too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently light template only support brightness. This PR adds temperature support.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11678
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: