Skip to content

Ease code before adding color and temperature to light template#30455

Merged
balloob merged 5 commits into
home-assistant:devfrom
tetienne:clean-light-template
Jan 7, 2020
Merged

Ease code before adding color and temperature to light template#30455
balloob merged 5 commits into
home-assistant:devfrom
tetienne:clean-light-template

Conversation

@tetienne
Copy link
Copy Markdown
Contributor

@tetienne tetienne commented Jan 3, 2020

Breaking Change:

N/A

Description:

In order to ease the review, I will split https://github.com/home-assistant/home-assistant/pull/28141/files in several smaller PR.
This one add some tests and split async_update to avoid huge method.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @PhracturedBlue, mind taking a look at this pull request as its been labeled with a integration (template) you are listed as a codeowner for? Thanks!

@tetienne tetienne mentioned this pull request Jan 3, 2020
9 tasks
@balloob balloob merged commit 13e6479 into home-assistant:dev Jan 7, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants