Add Buienradar camera for Belgium#30399
Merged
Merged
Conversation
Contributor
2 tasks
ties
approved these changes
Jan 2, 2020
Contributor
ties
left a comment
There was a problem hiding this comment.
This looks good.
There is no test for this functionality and I can not add commits to the pull request. You could add one (and clean up the split string added by black in test_camera.py) if you want.
Contributor
|
👍 nice additional feature. Was not aware of the Belgian maps when I added the camera. |
Contributor
Author
|
Shouldn't the PR be marked as reviewed now that everything is okay ? |
Contributor
Yes. But I can not do that :S. @frenck (due to timezone)? |
frenck
reviewed
Jan 8, 2020
frenck
reviewed
Jan 8, 2020
frenck
reviewed
Jan 8, 2020
frenck
reviewed
Jan 8, 2020
Member
frenck
left a comment
There was a problem hiding this comment.
I left a couple of small comments.
Contributor
Author
|
I have changed what you requested ! Thank you for the review @frenck |
springstan
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io/pull/11604
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: