Add belgian meter and rename some dsmr sensors#30121
Conversation
springstan
left a comment
There was a problem hiding this comment.
Reviewed your PR and found some small stuff, could you please view my comments? Thanks :)
|
@dupondje you will have to add some tests for the added functionality and a breaking change paragraph :) |
Where to add that breaking change paragraph? :) |
|
In the breaking change section of your PR (the filled out PR template) |
|
Should be all fine now :) |
|
@dupondje Looks good but it seems that you will need to add another test to pass the code coverage test :) |
|
Added some more tests :) Are we fine now? :) |
|
Unfortunately not, could you take a look at the codecoverage and adjust your tests respectively? :) |
|
Better now 👯♂️ |
|
can we get this one merged now? |
|
We can't actually, The upstream library needs to be fixed, because we can consider merging this PR. |
Breaking Change:
Some sensors were renamed. This because the suffix _low/_normal isn't valid in all cases.
Also DMSR Specs use Tarif 1 and Tarif 2.
Also fix Bug #24075
Description:
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11509
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: