Add separate command and state topics for mqtt lock

[tuxbox]

Allow different command and state topic + different command and state values.

Breaking Change:

Two new properties were introduced with state_locked (default: LOCKED) and state_unlocked (default: UNLOCKED). If you were using the same topic as state_topic as for the command_topic you can reestablish the old behaviour by setting state_locked to LOCK and state_unlocked to UNLOCK.
Effectively this change allows you to distinguish commands and states in two topics with different values.

Description:

Allows to separate command and state topics effectively. The configuration.yaml below results in action payloads to be LOCK / UNLOCK and expects a JSON in the state topic that contains at least a state field, e.g.:

{
  "state": "locked"
}

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11420

Example entry for configuration.yaml (if applicable):

lock:
  - platform: mqtt
    command_topic: "/dev/ha/lock/cmd"
    state_topic:   "/dev/ha/lock/state"
    value_template: "{{ value_json.state }}"
    state_locked: "locked"
    state_unlocked: "unlocked"

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [n/a] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• [n/a] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
• [n/a] Untested files have been added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[homeassistant]

Hi @tuxbox,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

[MartinHjelmare]

Please write the breaking change paragraph so we can copy it directly to the release notes. Briefly describe what has changed and what the user needs to do to cope with the breaking change.

[MartinHjelmare]

Tests need to be updated and the new config options tested.

[tuxbox]

I am just looking at this and hope to fix it quickly, thanks for looking at it so quickly

[tuxbox]

@MartinHjelmare I have updated the breaking change documentation and hope it works as expected, also the pipelines complete now, test cases were updated to reflect the new configuration options and abbreviations for the properties state_locked and state_unlocked were added. Anything else that needs to be done?

[MartinHjelmare]

Looks good! One comment.

[MartinHjelmare]

Looks good!