Skip to content

Add ZHA group API#29641

Merged
Adminiuga merged 18 commits into
home-assistant:devfrom
dmulcahey:dm/zha-group-api
Dec 9, 2019
Merged

Add ZHA group API#29641
Adminiuga merged 18 commits into
home-assistant:devfrom
dmulcahey:dm/zha-group-api

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

@dmulcahey dmulcahey commented Dec 8, 2019

Description:

This PR adds web socket commands needed to manage Zigbee groups from the front end. Still debating if I should break this up into multiple PR's.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

Comment thread homeassistant/components/zha/api.py Outdated
@dmulcahey dmulcahey marked this pull request as ready for review December 8, 2019 23:59
Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Adminiuga Adminiuga merged commit 1222aa8 into home-assistant:dev Dec 9, 2019
@lock lock Bot locked and limited conversation to collaborators Dec 10, 2019
@dmulcahey dmulcahey deleted the dm/zha-group-api branch March 26, 2020 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants