Skip to content

Support climate.set* for Tado Water Heaters#29191

Merged
michaelarnauts merged 1 commit into
home-assistant:devfrom
springstan:add-hot-water-device-tado
Nov 29, 2019
Merged

Support climate.set* for Tado Water Heaters#29191
michaelarnauts merged 1 commit into
home-assistant:devfrom
springstan:add-hot-water-device-tado

Conversation

@springstan
Copy link
Copy Markdown
Member

@springstan springstan commented Nov 28, 2019

Breaking Change:

Description:

  • added support for setting a tado hot water device via climate.set*
  • reference to documentation guide -> Turn on Hot Water

Related issue (if applicable): fixes #29013

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @michaelarnauts, mind taking a look at this pull request as its been labeled with a integration (tado) you are listed as a codeowner for? Thanks!

@springstan springstan changed the title Support climate.set* for Tado Hot Water Devices Support climate.set* for Tado Water Heaters Nov 29, 2019
@michaelarnauts
Copy link
Copy Markdown
Contributor

There is already an open PR that fixes this by using the water_heater component. See #27266

@springstan
Copy link
Copy Markdown
Member Author

Sorry did not see that one. Should I close this issue then?

@michaelarnauts
Copy link
Copy Markdown
Contributor

This fixes the issue when your heater has temperature control. #27266 also makes it work for heaters without temperature control, but there are still issues with that change, while these changes are working fine.

@michaelarnauts michaelarnauts merged commit 392cdf4 into home-assistant:dev Nov 29, 2019
@michaelarnauts michaelarnauts mentioned this pull request Nov 29, 2019
8 tasks
@michaelarnauts
Copy link
Copy Markdown
Contributor

I just noticed that you forgot to add the water heater code to turn it off. I'll add it in a new PR.

@springstan
Copy link
Copy Markdown
Member Author

@michaelarnauts thank you very much! :)

@lock lock Bot locked and limited conversation to collaborators Nov 30, 2019
@springstan springstan deleted the add-hot-water-device-tado branch December 16, 2019 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tado - use of service climate.set* with hot water device

3 participants