Support climate.set* for Tado Water Heaters#29191
Merged
michaelarnauts merged 1 commit intoNov 29, 2019
Merged
Conversation
|
Hey there @michaelarnauts, mind taking a look at this pull request as its been labeled with a integration ( |
Contributor
|
There is already an open PR that fixes this by using the |
michaelarnauts
approved these changes
Nov 29, 2019
Member
Author
|
Sorry did not see that one. Should I close this issue then? |
Contributor
|
This fixes the issue when your heater has temperature control. #27266 also makes it work for heaters without temperature control, but there are still issues with that change, while these changes are working fine. |
Contributor
|
I just noticed that you forgot to add the water heater code to turn it off. I'll add it in a new PR. |
Member
Author
|
@michaelarnauts thank you very much! :) |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
climate.set*Turn on Hot WaterRelated issue (if applicable): fixes #29013
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: