Skip to content

Change apns service domain and remove unused variable #29165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 3 commits into from
Nov 27, 2019
Merged

Change apns service domain and remove unused variable #29165

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49ba982
change apns service domain and remove unused variable
raman325 Nov 27, 2019
0b0eb08
fix tests
raman325 Nov 27, 2019
8089e4c
move DOMAIN to const.py and import DEVICE_TRACKER_DOMAIN from base co…
raman325 Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions homeassistant/components/apns/notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from homeassistant.components.notify import (
ATTR_DATA,
ATTR_TARGET,
DOMAIN,
PLATFORM_SCHEMA,
BaseNotificationService,
)
Expand All @@ -19,12 +18,12 @@
import homeassistant.helpers.config_validation as cv
from homeassistant.helpers.event import track_state_change

DOMAIN = "apns"
Comment thread
raman325 marked this conversation as resolved.
Outdated
APNS_DEVICES = "apns.yaml"
CONF_CERTFILE = "cert_file"
CONF_TOPIC = "topic"
CONF_SANDBOX = "sandbox"
DEVICE_TRACKER_DOMAIN = "device_tracker"
SERVICE_REGISTER = "apns_register"

ATTR_PUSH_ID = "push_id"

Expand Down
8 changes: 4 additions & 4 deletions tests/components/apns/test_notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def fake_write(_out, device):
self._setup_notify()

assert self.hass.services.call(
notify.DOMAIN,
apns.DOMAIN,
"apns_test_app",
{"push_id": "1234", "name": "test device"},
blocking=True,
Expand Down Expand Up @@ -153,7 +153,7 @@ def fake_write(_out, device):
self._setup_notify()

assert self.hass.services.call(
notify.DOMAIN, "apns_test_app", {"push_id": "1234"}, blocking=True
apns.DOMAIN, "apns_test_app", {"push_id": "1234"}, blocking=True
)

devices = {dev.push_id: dev for dev in written_devices}
Expand Down Expand Up @@ -183,7 +183,7 @@ def fake_write(_out, device):
self._setup_notify()

assert self.hass.services.call(
notify.DOMAIN,
apns.DOMAIN,
"apns_test_app",
{"push_id": "1234", "name": "updated device 1"},
blocking=True,
Expand Down Expand Up @@ -222,7 +222,7 @@ def fake_write(_out, device):
self._setup_notify()

assert self.hass.services.call(
notify.DOMAIN,
apns.DOMAIN,
"apns_test_app",
{"push_id": "1234", "name": "updated device 1"},
blocking=True,
Expand Down