Skip to content

Update service domain for mysensors from 'switch' to 'mysensors'#29147

Merged
frenck merged 1 commit into
home-assistant:devfrom
raman325:mysensors_service_update
Nov 27, 2019
Merged

Update service domain for mysensors from 'switch' to 'mysensors'#29147
frenck merged 1 commit into
home-assistant:devfrom
raman325:mysensors_service_update

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Nov 27, 2019

Breaking Change:

This change breaks existing service call references to the switch.mysensors_* services by changing the service calls to be mysensors.*.

Description:

Update the domain and service name for mysensors.*. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11331

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @MartinHjelmare, mind taking a look at this pull request as its been labeled with a integration (mysensors) you are listed as a codeowner for? Thanks!

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frenck frenck merged commit c80f284 into home-assistant:dev Nov 27, 2019
@raman325 raman325 deleted the mysensors_service_update branch November 27, 2019 14:00
@lock lock Bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants