Skip to content

Update service domain for html5 from 'notify' to 'html5' #29145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvizeli merged 1 commit into from
Nov 27, 2019
+14 −13
Merged

Update service domain for html5 from 'notify' to 'html5' #29145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions homeassistant/components/html5/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
"""Constants for the HTML5 component."""
DOMAIN = "html5"
SERVICE_DISMISS = "dismiss"
5 changes: 2 additions & 3 deletions homeassistant/components/html5/notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,16 @@
ATTR_TARGET,
ATTR_TITLE,
ATTR_TITLE_DEFAULT,
DOMAIN,
PLATFORM_SCHEMA,
BaseNotificationService,
)

from .const import DOMAIN, SERVICE_DISMISS

_LOGGER = logging.getLogger(__name__)

REGISTRATIONS_FILE = "html5_push_registrations.conf"

SERVICE_DISMISS = "html5_dismiss"

ATTR_GCM_SENDER_ID = "gcm_sender_id"
ATTR_GCM_API_KEY = "gcm_api_key"
ATTR_VAPID_PUB_KEY = "vapid_pub_key"
Expand Down
9 changes: 9 additions & 0 deletions homeassistant/components/html5/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
dismiss:
description: Dismiss a html5 notification.
fields:
target:
description: An array of targets. Optional.
example: ['my_phone', 'my_tablet']
data:
description: Extended information of notification. Supports tag. Optional.
example: '{ "tag": "tagname" }'
10 changes: 0 additions & 10 deletions homeassistant/components/notify/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,6 @@ notify:
description: Extended information for notification. Optional depending on the platform.
example: platform specific

html5_dismiss:
description: Dismiss a html5 notification.
fields:
target:
description: An array of targets. Optional.
example: ['my_phone', 'my_tablet']
data:
description: Extended information of notification. Supports tag. Optional.
example: '{ "tag": "tagname" }'

apns_register:
description: Registers a device to receive push notifications.
fields:
Expand Down