Skip to content

Update service domain for yamaha from 'media_player' to 'yamaha'#29142

Merged
pvizeli merged 2 commits into
home-assistant:devfrom
raman325:yamaha_service_update
Nov 27, 2019
Merged

Update service domain for yamaha from 'media_player' to 'yamaha'#29142
pvizeli merged 2 commits into
home-assistant:devfrom
raman325:yamaha_service_update

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Nov 27, 2019

Breaking Change:

This change breaks existing service call references to the media_player.yamaha_* services by changing the service calls to be yamaha.*.

Description:

Update the domain and service name for yamaha.*. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11316

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 27, 2019

Hi there, @raman325, a wild conflict has appeared, could you take a look? 👍

@raman325
Copy link
Copy Markdown
Contributor Author

resolved conflicts, this is due to me changing this file in multiple branches

@pvizeli pvizeli merged commit d577868 into home-assistant:dev Nov 27, 2019
@raman325 raman325 deleted the yamaha_service_update branch November 27, 2019 18:07
@lock lock Bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants