Skip to content

Update service domain for epson from 'media_player' to 'epson'#29113

Merged
balloob merged 3 commits into
home-assistant:devfrom
raman325:epson_service_update
Nov 26, 2019
Merged

Update service domain for epson from 'media_player' to 'epson'#29113
balloob merged 3 commits into
home-assistant:devfrom
raman325:epson_service_update

Conversation

@raman325
Copy link
Copy Markdown
Contributor

Breaking Change:

This change breaks existing service call references to the media_player.epson_select_cmode services by changing the service calls to be epson.select_cmode. My understanding is that because this is not a service provided by the base media_player component, it should live in the domain of the epson component instead. If that's the case, then it also makes sense to update the service name.

Description:

Update the domain and service name for epson.select_cmode. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@balloob balloob merged commit c216504 into home-assistant:dev Nov 26, 2019
@raman325 raman325 deleted the epson_service_update branch November 26, 2019 19:13
@lock lock Bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants