Skip to content

Update service domain for monoprice from 'media_player' to 'monoprice'#29099

Merged
balloob merged 1 commit into
home-assistant:devfrom
raman325:monoprice_service_update
Nov 26, 2019
Merged

Update service domain for monoprice from 'media_player' to 'monoprice'#29099
balloob merged 1 commit into
home-assistant:devfrom
raman325:monoprice_service_update

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Nov 26, 2019

Breaking Change:

This change breaks existing service call references to the media_player.snapshot and media_player.restore services by changing the service calls to be monoprice.snapshot and monoprice.restore respectively. My understanding is that because this is not a service provided by the base media_player component, it should live in the domain of the monoprice component instead. If that's the case, then it also makes sense to update the service name.

Description:

Update the domain and service name for media_player.snapshot and media_player.restore. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11297

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @etsinko, mind taking a look at this pull request as its been labeled with a integration (monoprice) you are listed as a codeowner for? Thanks!

@balloob balloob merged commit 499838d into home-assistant:dev Nov 26, 2019
@raman325 raman325 deleted the monoprice_service_update branch November 26, 2019 18:49
@lock lock Bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants