Skip to content

Update service domain for onvif from 'camera' to 'onvif'#29098

Closed
raman325 wants to merge 3 commits into
home-assistant:devfrom
raman325:onvif_service_update
Closed

Update service domain for onvif from 'camera' to 'onvif'#29098
raman325 wants to merge 3 commits into
home-assistant:devfrom
raman325:onvif_service_update

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Nov 26, 2019

Breaking Change:

This change breaks existing service call references to the camera.onvif_ptz by changing the service call to onvif.ptz. My understanding is that because this is not a service provided by the base camera component, it should live in the domain of the onvif component instead. If that's the case, then it also makes sense to update the service name.

Description:

Update the domain and service name for camera.onvif_ptz. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11294

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 26, 2019

This is being done in #29069, which is also introducing a new service.

@balloob balloob closed this Nov 26, 2019
@raman325 raman325 deleted the onvif_service_update branch November 26, 2019 18:50
@lock lock Bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants