Skip to content

Add attribute for storing one weather warning as a whole#29005

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
marecabo:feat-dwd-weather-warning-attribute
Apr 15, 2020
Merged

Add attribute for storing one weather warning as a whole#29005
MartinHjelmare merged 1 commit intohome-assistant:devfrom
marecabo:feat-dwd-weather-warning-attribute

Conversation

@marecabo
Copy link
Copy Markdown
Contributor

@marecabo marecabo commented Nov 23, 2019

Description:

This adds an attribute to the warning sensors from the DWD Weather warnings component. This new attribute contains the warning as a whole JSON object and thus enables the use of list-card to show the list of warnings in the UI easily.

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#11271

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
    (There has not been a test for the file in the first place.)

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @marecabo,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff fabaff changed the title add attribute for storing one weather warning as a whole Add attribute for storing one weather warning as a whole Nov 24, 2019
@springstan
Copy link
Copy Markdown
Member

@marecabo you can rerun the checks by closing and then reopening this PR :)

The error that is preventing the FullCheck Pylint from passing is unrelevant to your particular PR and has occurred for a lot of PRs, therefore a fix has been merged to solve it.

@marecabo marecabo closed this Nov 27, 2019
@marecabo marecabo reopened this Nov 27, 2019
@springstan
Copy link
Copy Markdown
Member

Looks like a very straightforward approach to this problem! 👍

@marecabo marecabo requested a review from elupus January 18, 2020 14:58
@stale
Copy link
Copy Markdown

stale Bot commented Mar 21, 2020

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale Bot added the stale label Mar 21, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 21, 2020

Thanks, stalebot, but this PR awaits an initial review from us.
Please keep open for now.

@stale stale Bot removed the stale label Mar 21, 2020
@MartinHjelmare MartinHjelmare removed the request for review from elupus April 15, 2020 00:25
@MartinHjelmare MartinHjelmare merged commit 0db1fcc into home-assistant:dev Apr 15, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants