Add attribute for storing one weather warning as a whole#29005
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom Apr 15, 2020
Merged
Conversation
Contributor
Merged
2 tasks
Member
Member
|
Looks like a very straightforward approach to this problem! 👍 |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Member
|
Thanks, stalebot, but this PR awaits an initial review from us. |
MartinHjelmare
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This adds an attribute to the warning sensors from the DWD Weather warnings component. This new attribute contains the warning as a whole JSON object and thus enables the use of list-card to show the list of warnings in the UI easily.
Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#11271
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices:
(There has not been a test for the file in the first place.)