Support for pi4ioe5v9xxxx I2C IO expanders#28847
Conversation
This comment has been minimized.
This comment has been minimized.
|
Docs now available in pull request home-assistant/home-assistant.io#11220 |
Bring up to date
…lake8 and black test now
Update to latest version
|
I can still see 2000+ changes with generic_thermostats changes. |
|
Ok, give me some time. I will fix it... |
|
Thanks Bdraco, for that info! I will use it for sure in future, but now the problems with thermostat are resolved. I have to fix some other minor issues in the checks, hope to do that tonight. Switch function is already tested and still works. Have to check sensor function still. |
Update to latest version
|
I just checked also the binary_sensor function. It works, but polling only happens every 30 seconds. I don't use the function myself, and I can imagine that faster is not really required, but in my machine-building experience a response time of 30 seconds is really slow. Is there a config option to increase the polling interval per sensor, or should I add a config parameter for that? Ah, already found. Adding scan_interval: 1 in the config makes is polling each second. |
Do you really need 1s frequency? That is going to create a bit of overhead since this integration isn't async. |
No, I don't need. Actually I don't need the binary_sensor even, but as I was writing the switch it was only a little effort to add the sensor as well. And I was curious if the polling interval can be reduced without writing code. The answer was: yes :) |
|
Any more changes coming or ready for another review pass? |
|
Ready for next review. |
|
@antonverburg Looks like this is blocked by the docs requests here: home-assistant/home-assistant.io#11220 Can you get that sorted out so we can merge? |
|
@bdraco A PR on the docs is not blocking the core. Docs can only block a core PR if it is missing. |
|
@antonverburg Ready for merge? |
|
Yes. Both in sensor mode & switch mode is tested and works. |
Description:
Added support for pi4ioe5v9xxxx I2C IO expanders
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11220
Example entry for
configuration.yaml(if applicable):