Add totalconnect zones as binary sensors#28712
Merged
springstan merged 60 commits intohome-assistant:devfrom Feb 1, 2020
Merged
Add totalconnect zones as binary sensors#28712springstan merged 60 commits intohome-assistant:devfrom
springstan merged 60 commits intohome-assistant:devfrom
Conversation
update to latest HA
it is a burglar or fire or carbon monoxide so automations can take appropriate actions. Updated TotalConnect component to handle these new states.
Also bumps total_connect_client to 0.27.
…. Bump total_connect_client to 0.28.
pull in latest
Contributor
Author
|
@springstan I think I have finally crossed the finish line. |
Member
|
Great to hear! I will take a look at it tomorrow to give you some feedback. |
springstan
reviewed
Jan 18, 2020
springstan
reviewed
Jan 18, 2020
springstan
reviewed
Jan 18, 2020
springstan
reviewed
Jan 18, 2020
springstan
reviewed
Jan 18, 2020
springstan
requested changes
Jan 18, 2020
already the name of the alarm.
Contributor
Author
|
I addressed all of your comments and changes, but I made changes locally instead of using the Github web interface. I think that's why it's still complaining you asked for changes. |
austinmroczek
commented
Jan 19, 2020
Contributor
Author
austinmroczek
left a comment
austinmroczek
left a comment
There was a problem hiding this comment.
I think this closes out the "review." Sorry still fairly new to git and Github.
springstan
approved these changes
Jan 20, 2020
springstan
changed the title
springstan
reviewed
Jan 21, 2020
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
Member
|
@MartinHjelmare could you please take a look at this to make sure I am not missing something? Thanks 👍 |
MartinHjelmare
requested changes
Jan 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Represent totalconnect "zones" as Home Assistant binary sensors.
This will add a large number of entities. It's 46 for my setup.
Related issue (if applicable): fixes craigjmidwinter/total-connect-client#2
**Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11160
Example entry for
configuration.yaml(if applicable):no changes to config
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: