Skip to content

Add switch platform to WLED integration#28606

Merged
frenck merged 3 commits into
devfrom
frenck-2019-0259
Nov 8, 2019
Merged

Add switch platform to WLED integration#28606
frenck merged 3 commits into
devfrom
frenck-2019-0259

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Nov 7, 2019

Description:

Adds the switch platform to the WLED integration, allowing the user to:

  • Toggle sync send
  • Toggle sync receive
  • Toggle Nightlight

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11120

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments.

Comment thread homeassistant/components/wled/__init__.py Outdated
Comment thread homeassistant/components/wled/switch.py
Comment thread homeassistant/components/wled/switch.py Outdated
@frenck frenck requested a review from MartinHjelmare November 8, 2019 07:58
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@frenck frenck merged commit b2071b8 into dev Nov 8, 2019
@delete-merged-branch delete-merged-branch Bot deleted the frenck-2019-0259 branch November 8, 2019 08:48
@lock lock Bot locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants