Skip to content

Better support multiple spotify instances#28505

Closed
uSpike wants to merge 3 commits into
home-assistant:devfrom
uSpike:dev
Closed

Better support multiple spotify instances#28505
uSpike wants to merge 3 commits into
home-assistant:devfrom
uSpike:dev

Conversation

@uSpike
Copy link
Copy Markdown
Contributor

@uSpike uSpike commented Nov 3, 2019

Breaking Change:

Spotify configuration for cache_path will now resolve to the home-assistant configuration directory by default.

Description:

Stores data by unique client_id, and configuration presents the name of the component to better differentiate multiple instances.

Fixes #27139

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@uSpike
Copy link
Copy Markdown
Contributor Author

uSpike commented Nov 15, 2019

Any chance this could be merged for the upcoming release?

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 16, 2019

@uSpike, no, the feature stop for 0.102 has been applied with the release of the first beta past Wednesday.

@uSpike
Copy link
Copy Markdown
Contributor Author

uSpike commented Dec 19, 2019

Any chance someone could look at this? I've also noticed there's no owner for the spotify component.

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 24, 2020

Superseded by #30717

@uSpike
Copy link
Copy Markdown
Contributor Author

uSpike commented Jan 24, 2020

Ok.

@uSpike uSpike closed this Jan 24, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple spotify instances not working

3 participants