Skip to content

Add scene.create service#28300

Merged
balloob merged 2 commits into
home-assistant:devfrom
Santobert:scene_create_service
Nov 1, 2019
Merged

Add scene.create service#28300
balloob merged 2 commits into
home-assistant:devfrom
Santobert:scene_create_service

Conversation

@Santobert
Copy link
Copy Markdown
Member

@Santobert Santobert commented Oct 28, 2019

Breaking Change:

Nothing breaks

Description:

Add scene.create service

Related issue (if applicable): fixes #27023

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11030

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (homeassistant) you are listed as a codeowner for? Thanks!

Comment thread homeassistant/components/scene/services.yaml
Comment thread homeassistant/components/homeassistant/scene.py Outdated
@Santobert Santobert changed the title WIP: Add scene.create service Add scene.create service Oct 29, 2019
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yessss

@balloob balloob merged commit 6655b7d into home-assistant:dev Nov 1, 2019
@Santobert Santobert deleted the scene_create_service branch November 1, 2019 22:55
@lock lock Bot locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add scene.create service

4 participants