Add device condition support for media_player#28161
Merged
Merged
Conversation
probot-home-assistant
Bot
added
Hacktoberfest
core
has-tests
integration: media_player
labels
Contributor
Author
|
Is there anything I need to do in home-assistant-polymer? When I went to see what it looked like in the UI, the condition dropdown items were all blank for me.
Also, what kind of documentation should I add, if any? |
Member
|
Great first contribution 👍 Run |
balloob
approved these changes
Oct 24, 2019
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
This looks great ! 🎉
Welcome to the Home Assistant community 🐬
Member
|
This can be merged when you format your code with Black so the tests pass 👍 You can run |
shmooey
force-pushed
the
device-condition-media
branch
from
55c98a4 to
5ee63b0
Compare
Contributor
Author
|
The formatting error was caused by #28171, I've rebased this branch so the Black issue is fixed now 😊 |
Member
|
Oh snap, didn't realize. Wish Black would give some more output so we know where to look. Great work ! 🐬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds basic device condition support for media_player integration - on, off, idle, paused, playing.
Related issue (if applicable): fixes #27004
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: