Allow multiple Transmission clients and add unique_id to entities#28136
Merged
Conversation
MartinHjelmare
changed the title
5 tasks
balloob
reviewed
Oct 23, 2019
balloob
requested changes
Oct 23, 2019
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
ok to merge when scan interval removed from the config flow.
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Some adjustments needed in a follow up PR. Looks good otherwise.
| hass.services.async_remove(DOMAIN, SERVICE_ADD_TORRENT) | ||
| if hass.data[DOMAIN][entry.entry_id].unsub_timer: | ||
| hass.data[DOMAIN][entry.entry_id].unsub_timer() | ||
| client = hass.data[DOMAIN][config_entry.entry_id] |
Member
There was a problem hiding this comment.
We could pop the client here already.
| """Update scan interval.""" | ||
|
|
||
| def refresh(event_time): | ||
| async def refresh(event_time): |
Member
There was a problem hiding this comment.
This should be reverted. The TransmissionData instance methods are not async safe.
| assert result["data"][CONF_PASSWORD] == PASSWORD | ||
| assert result["data"][CONF_PORT] == PORT | ||
| assert result["data"]["options"][CONF_SCAN_INTERVAL] == DEFAULT_SCAN_INTERVAL | ||
| # assert result["data"]["options"][CONF_SCAN_INTERVAL] == DEFAULT_SCAN_INTERVAL |
| assert result["data"][CONF_HOST] == HOST | ||
| assert result["data"][CONF_PORT] == PORT | ||
| assert result["data"]["options"][CONF_SCAN_INTERVAL] == DEFAULT_SCAN_INTERVAL | ||
| # assert result["data"]["options"][CONF_SCAN_INTERVAL] == DEFAULT_SCAN_INTERVAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Allow multiple Transmission Clients to be configured. Disable integration entities using the Entity Registry.
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: