-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move imports in wake_on_lan component #28100
Move imports in wake_on_lan component #28100
Conversation
Duplicate of #27415 |
@djpremier it was 5 days not 12 :/ @balloob - is there a policy on the time for dupes? |
Hi @inverse, I believe there is no time policy, I commented there because it is the information that is appearing to me here on Git (https://ibb.co/D42Z0HQ). As you did not respond, I decided to make the changes so that the issue could be closed as soon as possible, we are an Open Source community, we are here to help, sorry if I offended you in any way, it was not my intention. |
@djpremier I think there should be some policies around "trumping" PR's etc since that could demotivate people from contributing which would have an much more negative effect on an Open Source community than closing issues "as soon as possible". |
@inverse We don't have a policy for that, nor do I personally think that is needed. I'm sorry to hear that this has happened, however, this PR did pass the CI, the other didn't. It makes sense to merge the passing contribution. Closing it by saying: "Nope, great PR, but there is a dupe that needs to be fixed first" is awkward as well. In the end, what matters is that we move forward, so everybody can enjoy this great piece of software. This is not a competition. We value every contributor and contribution. Merged or not merged doesn't matter. So let me close by saying; Thanks @inverse, please don't be sad and I would definitely hope to see a contribution from you sometime again. ❤️ |
Description:
Moved imports from functions to top-level as requested in #27284
Checklist:
tox
. Your PR cannot be merged unless tests pass