Skip to content

Add override switch for juicenet#28049

Merged
fabaff merged 10 commits into
home-assistant:devfrom
jesserockz:juicenet-override
Nov 5, 2019
Merged

Add override switch for juicenet#28049
fabaff merged 10 commits into
home-assistant:devfrom
jesserockz:juicenet-override

Conversation

@jesserockz
Copy link
Copy Markdown
Member

Description:

Adds a switch to allow overriding car charging schedule

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10917

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/juicenet/switch.py Outdated
Comment thread homeassistant/components/juicenet/switch.py Outdated
Comment thread homeassistant/components/juicenet/switch.py Outdated
Comment thread homeassistant/components/juicenet/switch.py Outdated
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fabaff fabaff merged commit a43095b into home-assistant:dev Nov 5, 2019
@lock lock Bot locked and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants