Merged
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
|
Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration ( |
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add support for the Google Assistant Local SDK messages.
This is superduper alpha. There are a ton of bugs still on Google's side. This is what I have been able to cobble together and got it working. One bug is that your Google Assistant device will restart when it fails to do an HTTP request (ie when you restart Home Assistant).
Also, according to Google engineers that I have been in touch with, some of the things that we're doing are not supposed to work like that. So eh, we'll see. Wanted to get it out there so we can iterate on it.
The zeroconf integration has been updated to make sure that we only start broadcasting when Home Assistant is done starting up. This way we avoid broadcasting Home Assistant without being able to receive HTTP requests.
The JS receiver that runs on Google Assistant devices can be found here: https://github.com/NabuCasa/home-assistant-google-assistant-local-sdk
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: