Skip to content

SNMP Switch payloads are not guaranteed to be integers#27422

Merged
fabaff merged 1 commit intohome-assistant:devfrom
girlpunk:patch-1
Oct 12, 2019
Merged

SNMP Switch payloads are not guaranteed to be integers#27422
fabaff merged 1 commit intohome-assistant:devfrom
girlpunk:patch-1

Conversation

@girlpunk
Copy link
Copy Markdown
Contributor

Description:
SNMP can handle various payloads, including strings and other non-integers. This patch allows other types of payload.

Related issue (if applicable): fixes #27171

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A, no configuration changes

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated in home-assistant.io
    No changes to documented behaviour.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
    No changes to communication with devices

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff merged commit a712c9b into home-assistant:dev Oct 12, 2019
@lock lock Bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNMP Switch expects only integer to be returned

3 participants