Skip to content

Remove Plex manual config flow step#27291

Merged
balloob merged 1 commit into
home-assistant:devfrom
jjlawren:plex_remove_manual_flow
Oct 7, 2019
Merged

Remove Plex manual config flow step#27291
balloob merged 1 commit into
home-assistant:devfrom
jjlawren:plex_remove_manual_flow

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Oct 7, 2019

Description:

Remove manual configuration flow step. Manual configuration will only be available via YAML configuration.

Not breaking as this feature was never officially released.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10655

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@jjlawren
Copy link
Copy Markdown
Contributor Author

jjlawren commented Oct 7, 2019

Hey @balloob, also as requested. It was a big more invasive on the tests than I expected, but it looks ok. Up to you if you want to review/merge before the first Plex config flow release in 0.100.

@balloob balloob added this to the 0.100 milestone Oct 7, 2019
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@balloob balloob merged commit a3c9844 into home-assistant:dev Oct 7, 2019
@jjlawren jjlawren deleted the plex_remove_manual_flow branch October 7, 2019 20:53
balloob pushed a commit that referenced this pull request Oct 8, 2019
@lock lock Bot locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants