Fix the todoist integration#27273
Conversation
| @@ -206,7 +209,7 @@ def handle_new_task(call): | |||
| project_id = project_id_lookup[project_name] | |||
|
|
|||
| # Create the task | |||
There was a problem hiding this comment.
This call now requires a kwarg.
| @@ -216,11 +219,12 @@ def handle_new_task(call): | |||
| if PRIORITY in call.data: | |||
| item.update(priority=call.data[PRIORITY]) | |||
|
|
|||
There was a problem hiding this comment.
This is the primary change to get things working with the latest version. The due parameter is now an object
| else: | ||
| self._project_id_whitelist = [] | ||
|
|
||
| def _parse_due_date(self, data: dict) -> datetime: |
There was a problem hiding this comment.
Dates can be in 3 formats:
'2019-10-01'
'2019-10-01T12:00:00'
'2019-10-01T12:00:00Z'
|
Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️ Please, add your GitHub username to the For more information about "code owners", see: Architecture Decision Record 0008: Code owners. |
MartinHjelmare
changed the title
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Looks great! Thanks.
Because it fixes a current broken integration, I will go ahead and tag this for 0.100. It will be available in beta today, released on Wednesday 🎉
* Fixed the todoist integration. * Removing unused import * Flake8 fixes. * Added username to codeowners. * Updated global codeowners
4 participants
Description:
This fixes the todoist integration as mentioned in the forums. When
v8.0.0of the python library was released, the api changes were backwards-incompatible. This caused the current integration to fail to parse any data since the release.The main change is the
dueparameter is now an object rather than having separatedue_*properties. See the changelog.Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: